Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gl][Android] Fix integration with reanimated #28414

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

lukmccall
Copy link
Contributor

Why

Fixes integration with reanimated.
This PR fixes three problems discovered when trying the fix example in the NCL.

How

  • The GLView.getWorkletContext isn't correctly shared between js on the UI thread. I've decided to replace it with a global one.
  • enableExperimentalWorkletSupport wasn't enabled on our test view.
  • Assets weren't correctly converted into a sharable object because reanimated doesn't support moving prototypes between threads.

Test Plan

  • NCL ✅
Screen.Recording.2024-04-24.at.12.23.19.mov

@lukmccall lukmccall requested a review from tsapeta as a code owner April 24, 2024 10:35
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 24, 2024
@expo-bot
Copy link
Collaborator

The Pull Request introduced fingerprint changes against the base commit: 915a89d

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-gl",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "6cec04e799751f8f711083db9b11d1285f3a0753"
  }
]

Generated by PR labeler 🤖

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@lukmccall lukmccall merged commit 9004f96 into main Apr 24, 2024
1 check passed
@lukmccall lukmccall deleted the @lukmccall/gl/fix-integration-with-reanimated branch April 24, 2024 13:26
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 24, 2024
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants