Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-menu][iOS] Fix reloading app through "r" hotkey #28617

Merged
merged 2 commits into from May 4, 2024

Conversation

gabrieldonadel
Copy link
Member

Why

Closes ENG-12058

Similar to the issue reported by @Kudo on core (facebook/react-native#44241), triggering two immediate reloads when running an app using the new arch in bridgeless mode will cause the app to crash on iOS as well.

How

Instead of registering the "r" hotkey for the DevMenu reloadAction we can just rely on the default react-native reload action (which also uses the "r" hotkey)

Test Plan

Test dev-client through BareExpo and FabricTester

Checklist

Copy link

linear bot commented May 3, 2024

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 3, 2024
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels May 3, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented May 3, 2024

The Pull Request introduced fingerprint changes against the base commit: ab69adb

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-dev-menu",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "1fc55d96d54f2ac09137c13362de99d7130427c0"
  }
]

Generated by PR labeler 🤖

@brentvatne
Copy link
Member

thanks! this should be fine for now, but i wonder if we should be disabling all of the built-in react-native keyboard shortcuts rather than removing ours. we may want to revert this later

@brentvatne brentvatne merged commit d294dd4 into main May 4, 2024
20 checks passed
@brentvatne brentvatne deleted the @gabrieldonadel/fix-dev-menu-new-arch-reloading branch May 4, 2024 02:53
@brentvatne brentvatne added the published Changes from the PR have been published to npm label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants