[expo-speech][Web] Fix onDone
not firing listeners.
#28904
Merged
+13
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#28762
How
Instead of calling
DeviceEventEmitter
, we actually want to call emit on the current module – if we wrap it withcreateWebModule
it should ensure that this always has the emit method.Not sure if it's possible to type it better at this point (before moving to classes)
Test Plan
Events are now being called on web:
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).