[expo-notifications][Android] Ensure response is correctly mapped in useLastNotificationResponse hook #28938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…useLastNotificationResponse hook
douglowder
force-pushed
the
doug/eng-12137-android-notificationresponsereceivedlistener-not-called-when
branch
from
c676f0e
to
8ce35d9
Compare
expo-bot
added
bot: passed checks
christopherwalter
approved these changes
May 17, 2024
douglowder
deleted the
doug/eng-12137-android-notificationresponsereceivedlistener-not-called-when
branch
douglowder
added a commit
that referenced
this pull request
May 28, 2024
…useLastNotificationResponse hook (#28938)
douglowder
added a commit
that referenced
this pull request
Jun 12, 2024
…useLastNotificationResponse hook (#28938)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fix an omission in #28883 , where notification responses from Android have their data property correctly mapped for the response listener, but not for the useLastNotificationResponse hook.
How
Move the mapping to a utility method, and call that in both places where it is needed.
Test Plan
dataproperty inuseLastNotificationResponse()resultChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).