[docs] add last modification date to page Footer #29509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📘 Your docs preview website is ready! |
Simek
force-pushed
the
@simek/docs-show-page-latest-modification-date
branch
2 times, most recently
from
2122a52
to
b8901b9
Compare
Simek
force-pushed
the
@simek/docs-show-page-latest-modification-date
branch
from
3026965
to
f60f888
Compare
amandeepmittal
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Thank you! Looks amazing to me 🚀 Tested this locally by using `export-server.
Can I also ask you to add the modificationDate to https://docs.expo.dev/build-reference/infrastructure/ and remove the callout? 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It might be valuable in some cases for docs users to know when the page they are viewing has been updated.
How
Add last modification date to page Footer based on the data from git about latest commit. The information is appended to the Markdown files before executing a deploy build at the cost of 30s-60s of CI run time. Locally, the data is not present, and we show a placeholder - this is the unsual pattern for docs frameworks including this functionality, i.e Docusaurus or GitBook.
Test Plan
The changes have been reviewed locally in development and static modes.
Preview