Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli): add monorepo e2e test based on a custom fixture #29735

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Jun 13, 2024

Why

This is a draft to add a specific monorepo test to the exporting e2e tests.

How

  • We need a custom fixture for this, so I added one based on e2e/fixtures/with-router
  • Add a single test case that checks if both projects are not leaking code, based on static routes

Test Plan

Checklist

@byCedric
Copy link
Member Author

Ah yeah, the fixture is not connected to the source code, hence it's still failing.

@byCedric byCedric force-pushed the @bycedric/cli/add-monorepo-e2e-test branch from 20a891d to 0d12009 Compare June 23, 2024 21:26
@byCedric byCedric force-pushed the @bycedric/cli/add-monorepo-e2e-test branch from 1b090a5 to 7c07448 Compare June 24, 2024 08:31
@byCedric byCedric marked this pull request as ready for review June 24, 2024 08:32
@byCedric byCedric requested a review from EvanBacon as a code owner June 24, 2024 08:32
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against 7c07448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants