Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fingerprint): upgrade glob@7 to glob@10 #29927

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

byCedric
Copy link
Member

Why

Split off from #29808, specific to @expo/fingerprint

How

  • Upgraded glob@7 to glob@10
  • Removed globAsync wrapper in favor of default import { glob as globAsync } from 'glob'

Test Plan

See if CI and tests passes

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 21, 2024
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@byCedric byCedric requested a review from Kudo June 21, 2024 09:27
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 21, 2024
Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@byCedric byCedric merged commit c9516b1 into main Jun 23, 2024
28 checks passed
@byCedric byCedric deleted the @bycedric/fingerprint/upgrade-to-glob-10 branch June 23, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants