[sensors][iOS] Fix pedometer sensors when app goes to background then foreground #29957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…comes back active
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
lukmccall
approved these changes
Jun 24, 2024
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
expo-bot
reviewed
Jun 24, 2024
| @@ -13,6 +13,7 @@ | |||
| - Fix incorrect event emitting tests. ([#28953](https://github.com/expo/expo/pull/28953) by [@aleqsio](https://github.com/aleqsio)) | |||
| - Removed redundant usage of `EventEmitter` instance. ([#28946](https://github.com/expo/expo/pull/28946) by [@tsapeta](https://github.com/tsapeta)) | |||
| - [Android] Remove usage of deprecated internal modules API. ([#28715](https://github.com/expo/expo/pull/28715) by [@lukmccall](https://github.com/lukmccall)) | |||
| - [iOS] Fix pedometer sensor when app goes to background then foreground. ([#29957]https://github.com/expo/expo/pull/29957) by [@rlods](https://github.com/rlods)) | |||
There was a problem hiding this comment.
Suggested change
| - [iOS] Fix pedometer sensor when app goes to background then foreground. ([#29957]https://github.com/expo/expo/pull/29957) by [@rlods](https://github.com/rlods)) | |
| - [iOS] Fix pedometer sensor when app goes to background then foreground. ([#29957]https://github.com/expo/expo/pull/29957) by [@rlods](https://github.com/rlods)) ([#29957](https://github.com/expo/expo/pull/29957) by [@rlods](https://github.com/rlods)) |
expo-bot
added
bot: suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
On iOS, Pedometer sensor is currently broken if app goes to background then comes back in foreground.
It's very easy to reproduce:
Pedometer.watchStepCountPedometer.watchStepCountis subscribed againHow
The issue is that sensor reference values
watchStartDateandwatchHandlerare reset in stopUpdatesWhile they should only be reset in
OnStopObserving, which is also cleaner since both values are set in the opposite functionOnStartObservingTest Plan
Manually tested
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).