Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(expo-asset): Remove unused pathJoin function. #29963

Merged
merged 2 commits into from
Jun 25, 2024
Merged

chore(expo-asset): Remove unused pathJoin function. #29963

merged 2 commits into from
Jun 25, 2024

Conversation

EvanBacon
Copy link
Contributor

Why

  • I noticed in my tree-shaking prototype that this was consistently being removed. Turns out it's totally unused.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 23, 2024
@EvanBacon @expo-bot
Update packages/expo-asset/CHANGELOG.md
67fc8e1 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 23, 2024
@EvanBacon EvanBacon merged commit 3187776 into main Jun 25, 2024
25 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/expo-asset/remove-unused-function branch June 25, 2024 03:38
@EvanBacon EvanBacon mentioned this pull request Jul 2, 2024
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wschurman wschurman wschurman approved these changes

@aleqsio aleqsio Awaiting requested review from aleqsio aleqsio is a code owner

Assignees
No one assigned
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EvanBacon @wschurman @expo-bot