[android] flavorless builds #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esamelson
requested review from
sjchmiela,
nicknovitski,
fson and
tsapeta
and removed request for
fson
sjchmiela
approved these changes
Feb 1, 2019
esamelson
force-pushed
the
@eric/flavorless-builds
branch
from
2d238ea
to
4ebe99e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Instead of having
devKernelandprodKernelbuild flavors on our Android project (and thus all ExpoKit projects) we can just use the debug/release configuration to determine whether to use dev or prod home. In practice this is what we always do anyway (we never buildprodKernelDebug, for example) and this will make ExpoKit projects more similar to bare RN.How
BuildConfig.DEBUGto determine which kernel to runTest Plan
Ran
./gradlew installDebugand./gradlew assembleRelease, ensured that both ran the correct copies of home by looking at the manifest logged inadb logcat.