[UM][iOS] Fix bool variable representation #4862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ide
changed the title
ide
requested changes
Jul 8, 2019
lukmccall
force-pushed
the
@lukmccall/expo-sqlite-create-table-failed
branch
from
ce26812
to
512fde3
Compare
|
On older devices (with 32 bit iOS) BOOL type is represented by |
lukmccall
force-pushed
the
@lukmccall/expo-sqlite-create-table-failed
branch
from
512fde3
to
c0d7815
Compare
|
@lukmccall Could you also add changelog entry for that? Maybe not specifically for SQLite as I can imagine there are some more issues that might have been solved by this. |
According to objc.h bool variable can be represent as `bool` or `signed char`
lukmccall
force-pushed
the
@lukmccall/expo-sqlite-create-table-failed
branch
from
c0d7815
to
b1887aa
Compare
|
Hi @tsapeta , Is it released in SDK-33 as a fix? I facing with this issues on production right now. |
|
This will go out with SDK 34. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Resolve #4656
How
BOOL type in objective-c can be represented by
boolorsigned char(according to objc.h).We only check if BOOL variables are represented as a
bool.Test Plan
Test-suits passed on iPhone 5 and 8 simulator.
Also, you can check https://snack.expo.io/@lukaszkosmaty/[sqlite]-ios-fails-to-execute-%22create-table%22 (in particular, it works on iPhone 5).