Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ios][android] Drop SDK 31 and 32 #5381

Merged
merged 3 commits into from Aug 20, 2019
Merged

[ios][android] Drop SDK 31 and 32 #5381

merged 3 commits into from Aug 20, 2019

Conversation

Szymon20000
Copy link
Contributor

Why

resolves: #5146

How

Test Plan

Run NCL.

@tsapeta tsapeta changed the title Drop SDK 31 and 32 [iOS][Android] [ios][android] Drop SDK 31 and 32 Aug 19, 2019
tsapeta
tsapeta approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, thanks for taking care of this! 💪

@tsapeta tsapeta requested a review from sjchmiela August 19, 2019 12:40
@tsapeta tsapeta merged commit 8e23f9f into master Aug 20, 2019
@tsapeta tsapeta deleted the @szymon/drop_sdk_31_and_32 branch August 20, 2019 13:50
@cruzach cruzach mentioned this pull request Oct 11, 2019
Merged
tsapeta pushed a commit that referenced this pull request Oct 15, 2019
@cruzach @tsapeta
Add FileSystem.documentDirectory change to CHANGELOG (#5951)
1579bfc 
# Why

Migration was introduced [here](#3569), and removed [here](#5381), so if someone upgrades from SDK 32->35, it would pose a problem. We recommend upgrading one SDK at a time anyways, but just good to make this clear regardless

closes [5942](#5942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsapeta tsapeta tsapeta approved these changes

@sjchmiela sjchmiela Awaiting requested review from sjchmiela

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[expo] Drop SDKs 31 and 32
2 participants
@Szymon20000 @tsapeta