[Flutter] Update Unimodules Flutter Adapter #5632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjchmiela
requested changes
Sep 19, 2019
packages/expo-flutter-adapter/example/ios/Flutter/flutter_export_environment.sh
Outdated
Show resolved
Hide resolved
packages/expo-flutter-adapter/ios/Classes/ExpoFlutterAdapterPlugin.m
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
After the EX -> UM rename (EXCore -> UMCore, for example), the Flutter adapter needed to be updated to keep up with those changes.
How
I updated the podspec and gradle files for iOS and Android respectively to match the new unimodules framework package names.
Test Plan
Make sure that you have Flutter installed,
cdintopackages/expo-flutter-adapter/example,yarn, and runflutter runwith a connected physical device to test that the updated adapter works with the currently existing permissions and sensors PoC modules.Once approved/merged, I'll publish this update to the Flutter/Dart package registry, pub.dev.
Thanks!