Fix LinearGradient colors on web #5843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix lgtm but what caused this to regress in the first place? |
ide
approved these changes
Oct 2, 2019
packages/expo-linear-gradient/src/__tests__/LinearGradient-test.web.tsx
Outdated
Show resolved
Hide resolved
…t.web.tsx Co-Authored-By: James Ide <ide@users.noreply.github.com>
EvanBacon
deleted the
@evanbacon/expo-linear-gradient/fix-web-colors-again
branch
This was referenced Oct 8, 2019
EvanBacon
added a commit
that referenced
this pull request
Oct 9, 2019
* Fix web colors in SDK 35 * Update packages/expo-linear-gradient/src/__tests__/LinearGradient-test.web.tsx Co-Authored-By: James Ide <ide@users.noreply.github.com> * Fixed linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
fix expo/expo-cli#1035
How
Don't parse colors twice on web
Test Plan
New tests to catch colors but we should get NCL stood back up for web