[image-picker] Allow modal to be displayed in landscape orientation #5946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does your change affect behaviour on iOS prior version 13? |
Yes, but only those applications which are using |
|
How does it work with the dev menu (the modal that we display when you shake the device)? |
Dev menu displays and works properly. |
tsapeta
approved these changes
Oct 15, 2019
tsapeta
changed the title
lukmccall
force-pushed
the
@lukmccall/image-picker-fix-landscape-orientation
branch
from
512b2cd
to
db258b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Resolve #2020.
How
I've changed the
modal presentation styleforImagePickermodal. Sadly, I'm not sure if it what we want. For some reason, we put thereUIModalPresentationOverFullScreenearlier.On iOS 13
UIModalPresentationOverFullScreenmatches to app's orientation. However, on earlier systems, it forces portrait orientation. Also, I've done some research and checked what was used inreact-native-image-picker. They usedUIModalPresentationCurrentContext(https://github.com/react-native-community/react-native-image-picker/blob/085d0b7d087f603bea530be2cb94cf3c1719f036/ios/ImagePickerManager.m#L185).cc @tsapeta.
Test Plan