Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AV] Return empyt list as cookies list instead of null #6320

Merged
merged 3 commits into from Nov 19, 2019
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -36,6 +36,7 @@ This is the log of notable changes to the Expo client that are developer-facing.

### 🐛 Bug fixes

- Fixed `MediaPlayer` not working on some android devices by [@mczernek](http://github.com/mczernek) ([#6320](https://github.com/expo/expo/pull/6320))
tsapeta marked this conversation as resolved.
Show resolved Hide resolved
- Fixed `Audio.setAudioModeAsync` to auto-fill with previously set values (falls back to default values) if not all fields are provided by [@cruzach](https://github.com/cruzach) ([#5593](https://github.com/expo/expo/pull/5593))
- Fixed crash when `BarCodeScanner` was mounted more than 128 times. ([#5719](https://github.com/expo/expo/pull/5719) by [@geovannimp](https://github.com/geovannimp))
- Fixed URI parsing in `expo-video-thumbnails`. ([#5711](https://github.com/expo/expo/pull/5711) by [@lukmccall](https://github.com/lukmccall))
Expand Down
Expand Up @@ -420,7 +420,7 @@ private List<HttpCookie> getHttpCookiesList() {
}
return httpCookies;
} else {
return null;
return Collections.emptyList();
}
} catch (IOException e) {
// do nothing, we'll return an empty list
Expand Down