Created analytics module #6663
Closed
Created analytics module #6663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjchmiela
requested changes
Jan 10, 2020
packages/expo-firebase-analytics/ios/EXFirebaseAnalytics/EXFirebaseAnalytics.m
Outdated
Show resolved
Hide resolved
packages/expo-firebase-analytics/ios/EXFirebaseAnalytics/EXFirebaseAnalytics.m
Outdated
Show resolved
Hide resolved
packages/expo-firebase-analytics/ios/EXFirebaseAnalytics/EXFirebaseAnalytics.m
Outdated
Show resolved
Hide resolved
sjchmiela
requested changes
Jan 10, 2020
IjzerenHein
reviewed
Jan 10, 2020
There was a problem hiding this comment.
I'm still wrapping my mind around everything that is Expo, but here are couple comments so far from my side.
Generally, everything looks pretty good. 👍 As for the Firebase App initialization, we should probably move that to a separate module later on, but it's find to keep this in here for now.
...analytics/android/src/main/java/expo/modules/firebase/analytics/FirebaseAnalyticsModule.java
Outdated
Show resolved
Hide resolved
| @@ -55,6 +55,8 @@ export function getTestModules() { | |||
|
|
|||
| if (Platform.OS === 'android') { | |||
| modules.push(require('./tests/JSC')); | |||
| } else if (Platform.OS === 'ios') { | |||
| modules.push(require('./tests/FirebaseAnalytics')); | |||
There was a problem hiding this comment.
else should indeed be removed here, implies that there is a relationship with the JSC test above, but there isn't.
Currently all the tests fail on Android, so it's better to keep them disabled until fixed.
|
@EvanBacon we are interested in all Firebase services in managed flow. Would you please explain what will change after this PR will be merged for us? :) |
EvanBacon
commented
Jan 31, 2020
|
Moved to #7017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Utilize some of the existing Google Services that we include with expo-notifications.
AdSupportIDFA analytics feature of Firebase disable_idfa_collectionHow
expo-firebase-analytics(from scratch) which does the most bare-bones binding to the native Firebase analytics packages.Test Plan
bare-exposhould show analytics working in the Firebase console. You'll want to start the native app in debug mode (this should modifyapps/bare-expo/ios/BareExpo.xcodeproj/xcshareddata/xcschemes/BareExpo.xcscheme).GoogleServices-info.plistinbare-expothen build the app and use the following to start the native iOS app at runtime (this seems to not work for analytics on Android) (bare expo currently runs this in CI on iOS)