Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-notifications] Smaller fixes #6790

Merged
merged 2 commits into from Feb 4, 2020
Merged

[expo-notifications] Smaller fixes #6790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad86fa1
[expo-notifications] Move fetching EventEmitter higher
sjchmiela Jan 15, 2020
0df97b6
[expo-notifications] Fix wrong placement of const
sjchmiela Jan 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...otifications/android/src/main/java/expo/modules/notifications/tokens/PushTokenModule.java
View file
Open in desktop
Expand Up @@ -41,12 +41,12 @@ public String getName() {

@Override
public void onCreate(ModuleRegistry moduleRegistry) {
mEventEmitter = moduleRegistry.getModule(EventEmitter.class);

// Register the module as a listener in PushTokenManager singleton module.
// Deregistration happens in onDestroy callback.
mPushTokenManager = moduleRegistry.getSingletonModule("PushTokenManager", PushTokenManager.class);
mPushTokenManager.addListener(this);

mEventEmitter = moduleRegistry.getModule(EventEmitter.class);
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions packages/expo-notifications/ios/EXNotifications/EXPushTokenModule.m
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@

#import <UMCore/UMEventEmitterService.h>

static const NSString *onDevicePushTokenEventName = @"onDevicePushToken";
static NSString * const onDevicePushTokenEventName = @"onDevicePushToken";

@interface EXPushTokenModule ()

Expand Down Expand Up @@ -57,7 +57,7 @@ - (void)setModuleRegistry:(UMModuleRegistry *)moduleRegistry

- (NSArray<NSString *> *)supportedEvents
{
return @[(NSString *)onDevicePushTokenEventName];
return @[onDevicePushTokenEventName];
}

- (void)startObserving
Expand Down Expand Up @@ -102,7 +102,7 @@ - (void)onDidRegisterWithDeviceToken:(NSData *)devicePushToken
}

if (_isBeingObserved) {
[_eventEmitter sendEventWithName:(NSString *)onDevicePushTokenEventName
[_eventEmitter sendEventWithName:onDevicePushTokenEventName
body:@{ @"devicePushToken": stringToken }];
}
}
Expand Down