Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-permissions] Make it extendable by expo-notifications #6917

Merged
merged 3 commits into from Feb 3, 2020
Merged

[expo-permissions] Make it extendable by expo-notifications #6917

merged 3 commits into from Feb 3, 2020

Commits on Jan 30, 2020

  1. [expo-permissions] Make remote notification requester reusable 

    EXRemoteNotificationPermissionRequester doesn't need to depend on the concrete class of EXUserNotificationPermissionRequester. By replacing the concrete class with an interface, we can plug in any other requester (eg. from another unimodule)
    @sjchmiela
    sjchmiela committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    5c5936a View commit details
    Browse the repository at this point in the history

  2. [expo-permissions] Always fetch requesters by a method getter 

    This will let us insert fallback requesters at the last minute
    @sjchmiela
    sjchmiela committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    3b3e783 View commit details
    Browse the repository at this point in the history

  3. [expo-permissions] Add fallback requesters retroactively 

    If permission requesters for `notifications` and/or `userFacingNotifications` have been registered (by eg. `expo-notifications`), we don't need to provide our fallbacks.
    @sjchmiela
    sjchmiela committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    25e4027 View commit details
    Browse the repository at this point in the history