[expo-notifications] Small fixes #7069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjchmiela
force-pushed
the
@sjchmiela/expo-notifications-small-fixes
branch
from
3c78b31
to
a6a166f
Compare
# Conflicts: # packages/expo-notifications/android/build.gradle
sjchmiela
force-pushed
the
@sjchmiela/expo-notifications-small-fixes
branch
from
e6a8aa5
to
dd641d0
Compare
tsapeta
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Didn't want to put these changes inside another PR.
How
androidx:coreis available"sound":falsein the notification request made the notification play a soundTest Plan
None, it just works.