Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-contacts] Fix presentFormAsync pre-filling #7285

Merged
merged 3 commits into from
Mar 9, 2020

Conversation

lukmccall
Copy link
Contributor

Why

Fixes #6401.

How

See the original PR. Some of the issues were fixed in SDK 35. However, we still need to fix some of them.

Test Plan

public String getDisplayName() {
if (displayName == null) {
if (firstName != null) {
if (lastName != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many ifs 😅 Maybe we can make it simpler? Also, what if firstName == null? Shouldn't we return lastName then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it simpler ;)

We shouldn't return only lastName, cause then Android will interpret this value as a first name.

@lukmccall lukmccall force-pushed the @lukmccall/expo-contacts-fix-presentFormAsync branch from 9a43090 to aff9b83 Compare March 9, 2020 12:34
@lukmccall lukmccall merged commit 958d95f into master Mar 9, 2020
@lukmccall lukmccall deleted the @lukmccall/expo-contacts-fix-presentFormAsync branch March 9, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contacts - firstName, lastName, addresses and image not working
2 participants