Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs added expo-server-sdk-dotnet to list #7379

Merged
merged 1 commit into from Mar 18, 2020
Merged

Conversation

glyphard
Copy link
Contributor

Why

Added dotnet sdk version link discussed here
https://forums.expo.io/t/expo-expo-server-sdk-dotnet/33807

How

implemented in dotnet and then updated docs

Test Plan

Used preview to check formatting on docs

@ide
Copy link
Member

ide commented Mar 18, 2020

Before adding this, could you please add rate-limiting to the library so that it opens at most 6 HTTP connections at a time?

Copy link
Member

@ide ide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Node SDK demonstrates how to do rate limiting and also how to compress requests.

@byCedric
Copy link
Member

This might also help fixing the concurrent connections, https://codeburst.io/throttling-concurrent-outgoing-http-requests-in-net-core-404b5acd987b

@glyphard
Copy link
Contributor Author

Added connection throttling limit to 6 concurrent connections and updated.
No change required to the documentation.

@ide ide merged commit 07ceb6e into expo:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants