Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-screen-orientation][web] Fix lockAsync and orientation change listener #7774

Merged
merged 3 commits into from
Apr 9, 2020
Merged

[expo-screen-orientation][web] Fix lockAsync and orientation change listener #7774

merged 3 commits into from
Apr 9, 2020

Conversation

awinograd
Copy link
Contributor

Why

Fixes #7618
Fixes lookup up OrientationLock value passed into lockAsync

How

Web support for expo-screen-orientation did not match the docs / native support

Test Plan

yarn linked the package in my app repository. Verified my addOrientationChangeListener receives the proper payload and that lockAsync doesn't throw Invalid Orientation Lock:

@awinograd awinograd marked this pull request as ready for review April 9, 2020 17:35
@EvanBacon EvanBacon self-assigned this Apr 9, 2020
Copy link
Contributor

@EvanBacon EvanBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this!

@EvanBacon EvanBacon merged commit 837eac5 into expo:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[expo-screen-orientation] Wrong property name in emitted event
2 participants