[docs] fix broken links on get started and guides #7992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
commented
Apr 24, 2020
| @@ -25,7 +25,7 @@ function githubUrl(path) { | |||
| } else { | |||
| path = path.replace('/versions/latest/', '/versions/unversioned/'); | |||
| } | |||
| } else if (path.match(/v\d+\.\d+\.\d+\/?$/)) { | |||
| } else if (path.match(/v\d+\.\d+\.\d+\/?$/) || path === '/') { | |||
There was a problem hiding this comment.
Fixes the Edit on GitHub from the intro page.
byCedric
force-pushed
the
fix/docs-broken-links
branch
from
b1494c9
to
6e770a8
Compare
byCedric
commented
Apr 24, 2020
| @@ -157,8 +157,6 @@ There are four major GraphQL clients available at the moment: | |||
|
|
|||
| Apollo, Relay and Urql implement further features like caching, realtime support with GraphQL subscriptions or optimistic UI updates. | |||
|
|
|||
| Learn how to integrate with Auth0 social providers in the [expo-auth0-example](https://github.com/graphcool-examples/react-native-graphql/tree/master/authentication-with-expo-and-auth0) repository. | |||
There was a problem hiding this comment.
This is now outdated and not supported, graphcool also doesn't exist anymore (now prisma). 馃槄 This page could use a refresh
brentvatne
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I ran a full check of all links, there is still a lot left in the API reference. But this fixes the "Get Started" and "Guides" sections. (Fixes #7985)
How
Ran export locally and double-checked the links.
Test Plan
Could be great if we can detect internal links and/or headers by ESLint or something related 馃槃