Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[calendar] Make sourceId parameter optional when creating a calendar #8570

Merged
merged 5 commits into from Jun 1, 2020
Merged

[calendar] Make sourceId parameter optional when creating a calendar #8570

merged 5 commits into from Jun 1, 2020

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented May 29, 2020 •
edited

Why

Some tests (especially for reminders) in test-suite were failing for me because I use weird setup of calendars on my device and it wasn’t so easy to find proper source where to put compatible calendar — sourceId parameter was required but we can actually use the one that is default to given entityType.

How

  • Made sourceId optional in createCalendarAsync.
  • Extracted tests to separate tests screen so it's easier to test & debug specific part of expo-calendar API.
  • Changed docs accordingly, however imho this docs page is asking us for some more love 😞

Test Plan

Now all expo-calendar tests in test-suite are passing on my device.

@github-actions
Copy link
Contributor

Native Component List for this branch is ready

@tsapeta tsapeta marked this pull request as ready for review May 29, 2020 22:52
@tsapeta tsapeta requested a review from lukmccall as a code owner May 29, 2020 22:52
lukmccall
lukmccall approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏅

@tsapeta tsapeta merged commit aa2d439 into master Jun 1, 2020
@tsapeta tsapeta deleted the @tsapeta/qa/calendar branch June 1, 2020 09:48
tsapeta added a commit that referenced this pull request Jun 1, 2020
@tsapeta
[calendar] Make sourceId parameter optional when creating a calendar (
82ea7c3 
#8570)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukmccall lukmccall lukmccall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsapeta @lukmccall