Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-file-system] Fix getInfo returning incorrect size when provided path points to folder #9063

Conversation

lukmccall
Copy link
Contributor

@lukmccall lukmccall commented Jul 2, 2020

Why

Fixes #9054.

Test Plan

  • test-suite:
    • iOS ✅
    • Android ✅

Changelog

  • Fixed getInfo returning incorrect size when provided path points to a folder.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2020

Native Component List for this branch is ready

Copy link
Contributor

@bbarthec bbarthec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lukmccall pushed a commit that referenced this pull request Jul 2, 2020
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@lukmccall lukmccall force-pushed the @lukmccall/file-system/get-info-returns-incorrect-size-for-folders branch from f79b1d5 to 01d8f00 Compare July 3, 2020 07:21
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@lukmccall lukmccall merged commit d12a868 into master Jul 3, 2020
@lukmccall lukmccall deleted the @lukmccall/file-system/get-info-returns-incorrect-size-for-folders branch July 3, 2020 08:00
@danilocanalle
Copy link

Wooooooww nice @lukmccall its on production ?

@lukmccall
Copy link
Contributor Author

@danilo900, unfortunately, no :/

@danilocanalle
Copy link

Oh, Lets wait then ...
Thanks

@danilocanalle
Copy link

danilocanalle commented Jul 10, 2020

How can I get that version ?

Sorry for that question, but Iam newbie on those things.

I saw that is already merged on Master.
But, I cant get that updated version if I simple install expo-file-system. =/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expo-file-system getInfoAsync wrong folder size
3 participants