[expo-image-picker] Fixed downsizing cropped image on iOS #9316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barthap
changed the title
barthap
changed the title
tsapeta
approved these changes
Jul 21, 2020
This was referenced Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #8079
How
Instead of getting
UIImagePickerControllerEditedImagewhich is cropped and downsized, I take the original image and cropping rect, then crop it manually.Based on this thread, however instead of rotating the cropping rect, I took advantage of already implemented
fixOrientationand it seems to work.Images are cropped correctly and aren't downsized anymore.
Test Plan
Test using demo from issue. Tested portrait and landscape images, as well as rotated images.