Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ncl] Add typings for VideoPlayer example #9335

Merged
merged 1 commit into from
Jul 22, 2020
Merged

[ncl] Add typings for VideoPlayer example #9335

merged 1 commit into from
Jul 22, 2020

Conversation

IjzerenHein
Copy link
Contributor

@IjzerenHein IjzerenHein commented Jul 21, 2020 •
edited

Why

To improve code readability

Follows up on #9323

How

  • Remove any and add types for events
  • Restructured state to include status field

Test Plan

  • Tested NCL example locally and verified all examples work as expected

@IjzerenHein IjzerenHein mentioned this pull request Jul 21, 2020
Merged
@github-actions
Copy link
Contributor

Native Component List for this branch is ready

Base automatically changed from @hein/expo-av/lifecycle-events to master July 21, 2020 15:25
@IjzerenHein IjzerenHein force-pushed the @hein/expo-av/ncl-example-update branch from 037c67f to 671195a Compare July 21, 2020 15:32
bbarthec
bbarthec approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@bbarthec bbarthec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@IjzerenHein IjzerenHein merged commit 9198be6 into master Jul 22, 2020
@IjzerenHein IjzerenHein deleted the @hein/expo-av/ncl-example-update branch July 22, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbarthec bbarthec bbarthec approved these changes

@mczernek mczernek Awaiting requested review from mczernek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IjzerenHein @bbarthec