Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[home][chore] migrate to react navigation v5 #9345

Merged
merged 12 commits into from
Jul 23, 2020
Merged

[home][chore] migrate to react navigation v5 #9345

merged 12 commits into from
Jul 23, 2020

Conversation

EvanBacon
Copy link
Contributor

Why

How

  • Remove old react-navigation
  • Migrate to new theme system
  • Fix all remaining style bugs on Android
  • Migrate more to TypeScript
  • Use new theme provider for dev menu

Test Plan

  • Manually tested on physical devices and iOS simulator
    • Ensure the NavigationEvents shim continues to work
    • Ensure the dev menu respects the style defined in home
    • Ensure status bar respects color scheme

@EvanBacon EvanBacon added home The user interface for the generic development client enhancement New feature or request labels Jul 22, 2020
@EvanBacon EvanBacon requested review from brentvatne and ide July 22, 2020 02:00
@EvanBacon EvanBacon self-assigned this Jul 22, 2020
@EvanBacon EvanBacon marked this pull request as ready for review July 22, 2020 03:10
@EvanBacon EvanBacon merged commit 09fa69c into master Jul 23, 2020
@EvanBacon EvanBacon deleted the @evanbacon/home/react-navigation-v5-migration branch July 23, 2020 22:20
@ide ide mentioned this pull request Jul 28, 2020
Closed
5 tasks
prakashbask pushed a commit to prakashbask/expo that referenced this pull request Mar 16, 2022
@EvanBacon @brentvatne
[home][chore] migrate to react navigation v5 (expo#9345)
d6d8c5e 
* Migrate to react-navigation v5

* Updated types

* Remove react-navigation

* Improve analytics

* Fixed form auto focus

* Delete Form.js

* Fix sign out button style

* Remove comments

* Add back scroll to top tabs behavior

* Fix status bar when switching from active app back to home on Android

* Fix back button image resolution in monorepo for home and ncl

* Fix lint

Co-authored-by: Brent Vatne <brentvatne@gmail.com>
This was referenced Mar 31, 2022
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentvatne brentvatne brentvatne approved these changes

@ide ide Awaiting requested review from ide

Assignees

@EvanBacon EvanBacon

Labels
enhancement New feature or request home The user interface for the generic development client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate client to react-navigation v5
2 participants
@EvanBacon @brentvatne