[expo-av] De-activate audio-session after unloading sound #9365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Shared audio-session is not de-activated after unloading Sound.
How
When unloading a Sound using
Sound.unloadAsync
, the audio-session was not de-activated, although there we no longer any active AV objects. This happened because thedemoteAudioSessionIfPossible
was called before the sounds was removed from the_soundDictionary
, which in turn made it think there was still 1 active AV object.Test Plan