[expo-updates] Fetch asset manifest through programmatic CLI interface instead of depending on a running React Native CLI server #9372
Conversation
…pending on a running React Native CLI server
brentvatne
changed the title
…e instead of depending on a running React Native CLI server (#9372) * Fetch asset manifest through programmatic CLI interface instead of depending on a running React Native CLI server * Update CHANGELOG
|
@brentvatne This PR broke building iOS project on RN On |
|
i think you can override the PROJECT_ROOT option in your build phases to make it whatever you like to resolve the issue. can you suggest an alternative that will work on 0.62 and 0.63? |
|
@brentvatne I was able to resolve issue by adjusting EDIT: Actually i was not able, i just downgraded to the previous |
|
we could possibly add a conditional to handle this for 0.63+ |
…anifest - #9372 (comment) - I was unable to reproduce it but if the reported cause is correct then this should resolve it.
…anifest - #9372 (comment) - I was unable to reproduce it but if the reported cause is correct then this should resolve it.
|
@todorone - i tried to reproduce this on a new 0.63 project and i was unable to. i created a new project and installed expo-updates on it and the release build worked as expected. given your description of the problem i attempted a fix: a566b2a
|
|
@brentvatne New version works perfect for me, thanks! |
Why
Fixes this issue: #8374
Basically you want to be able to run
./gradlew :app:assembleReleasewithout running a React Native CLI server beforehand, and this makes it possible to do so.How
ServerAPI that is used byreact-native bundlein the previous build phase.@expo/metro-configto configure Metro, because we don't want to depend on the private configuration code that is internal to@react-native-community/cli.Test Plan
I patched these changes into an existing bare project and it worked properly on iOS and Android. It was able to unblock me to build on the build service.