[expo-av] Fix onReadyForDisplay not emitted for HLS streams/m3u8 files on iOS #9443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IjzerenHein
changed the title
|
Native Component List for this branch is ready |
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
…s on iOS (expo#9443) * [test] Add onReadyForDisplay test for HLS streams * [expo-av] Fix onReadyForDisplay not emitted on HSL streams * [test] Update onReadyForDisplay test for HSL streams * [ncl] Revert test changes * [expo-av] Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #3649. When using an HLS stream (e.g. a m3u8 file) with the
<Video>component,onReadyForDisplayis never called because the natural-size cannot be obtained on an asset of type AVURLAsset.How
Test Plan