Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[media-library] Add unit tests to module #9538

Merged
merged 11 commits into from Aug 5, 2020
Merged

[media-library] Add unit tests to module #9538

merged 11 commits into from Aug 5, 2020

Conversation

barthap
Copy link
Contributor

@barthap barthap commented Aug 4, 2020 •
edited

Why

MediaLibrary has many utility methods, which behavior is sometimes unclear. Unit tests would describe that behavior.

Also, contains some minor fixes.

How

  • Add native unit tests to MediaLibrary on Android.
  • Fixes bug, where getAssetsAsync() could return without promise rejection, when caught IOException
  • Adds a little input validation to module methods
  • Removes unused test dependencies from expo-web-browser.

Test plan

et android-native-unit-tests

WIP

  • Add testing dependencies
  • Add utility functions to mock ContentResolver
  • Test GetQueryInfo
  • Test MediaLibraryUtils where possible
  • Test GetAssets
  • Test GetAssetInfo
  • Extract useful test utility functions to unimodules-test-core
  • Input validation and minor refactors

@barthap barthap requested a review from lukmccall August 4, 2020 05:56
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2020

Native Component List for this branch is ready

@barthap barthap requested a review from bbarthec August 4, 2020 10:47
@barthap barthap marked this pull request as ready for review August 4, 2020 13:27
lukmccall
lukmccall approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

packages/expo-media-library/android/src/test/java/expo/modules/medialibrary/MockData.kt Outdated Show resolved Hide resolved
packages/expo-media-library/android/src/test/java/expo/modules/medialibrary/MockData.kt Outdated Show resolved Hide resolved
packages/expo-media-library/android/src/test/java/expo/modules/medialibrary/MockData.kt Outdated Show resolved Hide resolved
packages/expo-media-library/android/src/test/java/expo/modules/medialibrary/TestUtils.kt Show resolved Hide resolved
packages/expo-media-library/src/MediaLibrary.ts Show resolved Hide resolved
bbarthec
bbarthec approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@bbarthec bbarthec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

barthap and others added 2 commits August 5, 2020 10:50
@barthap @lukmccall
Apply suggestions from code review
2b1b8f6 
Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com>
@barthap
Build JS
6c1db3e
@lukmccall lukmccall merged commit c6f3677 into master Aug 5, 2020
@lukmccall lukmccall deleted the @barthap/media-library/unit-tests branch August 5, 2020 10:03
@dependabot dependabot bot mentioned this pull request Mar 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukmccall lukmccall lukmccall approved these changes

@bbarthec bbarthec bbarthec approved these changes

@mczernek mczernek Awaiting requested review from mczernek

@sjchmiela sjchmiela Awaiting requested review from sjchmiela

@tsapeta tsapeta Awaiting requested review from tsapeta tsapeta is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@barthap @lukmccall @bbarthec