[expo-av] Fix Video resizeMode not updated on Android #9567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IjzerenHein
changed the title
|
Native Component List for this branch is ready |
bbarthec
approved these changes
Aug 5, 2020
IjzerenHein
force-pushed
the
@hein/expo-av/android-resizemode-fix
branch
from
a3bf75c
to
aac7af9
Compare
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
* [expo-av] Fix resizeMode changes not visible * [expo-av] Update to prev commit, only invalidate when needed * [expo-av] Only update resizeMode when needed * [expo-av] Update changelog * [expo-av] Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Changing the Video resizeMode does not always update the visible content.
In the video you can see how changing the resizeMode quickly causes the video to sometimes display the content with the previously selected resizeMode. This happens in the recording when the "contain" and "cover" modes are chosen.
How
After investigating it was found that changing the
transformon the TextureView does not automatically redraw the view. Instead, the view was redrawn only when the PlayerData sent new data to the underlying surface. When for instance a video was paused or stopped, it would not update the TextureView.invalidationcall whenever the transform-matrix on the TextureView changedTest Plan