[expo-av] Fix Video blank after unlocking screen #9586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IjzerenHein
force-pushed
the
@hein/expo-av/android-fix-blank-on-resume
branch
from
8de6279
to
7deab42
Compare
bbarthec
approved these changes
Aug 6, 2020
IjzerenHein
force-pushed
the
@hein/expo-av/android-fix-blank-on-resume
branch
from
7deab42
to
44b4109
Compare
|
Native Component List for this branch is ready |
IjzerenHein
force-pushed
the
@hein/expo-av/android-fix-blank-on-resume
branch
from
44b4109
to
08100c6
Compare
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
* [expo-av] Fix Video blank after unlocking screen * [expo-av] Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When unlocking the screen, the Video component sometimes displays nothing (blank) after unlocking the phone.
Fixes #2527
How
After investigation and debugging it was found that the Android TextureView contains a bug which causes the hardware layer to be destroyed, but not recreated. Only after certain events such as a Frame update on the surface, or detecting a visibility change, the layer would be recreated.
Test Plan
Reproduction steps
before