[expo-av] Fix exception on Android when loading invalid Video source #9596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
Bug-Generator
approved these changes
Aug 6, 2020
Comment on lines
400
to
+406
| } | ||
|
|
||
| mPlayerData.setStatusUpdateListener(mStatusUpdateListener); | ||
|
|
||
| if (mMediaController == null) { | ||
| mMediaController = new MediaController(VideoView.this.getContext()); | ||
| } |
There was a problem hiding this comment.
Run linter to parry this, update changeLog and this should be good to go
There was a problem hiding this comment.
Thanks for taking a look! Updated the changelog 👍
Run linter to parry this
Please elaborate
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
…xpo#9596) * [expo-av] Fix exception on Android when loading invalid Video source * [expo-av] Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fix invalid state when loading a source fails. This leads to an exception when loading a new source.
Fixes #9185
How
When an error occurred, the MediaController was cleaned up. Upon loading a new source after that, an exception occurred because the
mMediaControllervariable was null.Test Plan
Steps to reproduce: