Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[media-library] Fix getAlbumsAsync() crashing on Android 10 #9666

Merged
merged 6 commits into from Aug 12, 2020
Merged

[media-library] Fix getAlbumsAsync() crashing on Android 10 #9666

merged 6 commits into from Aug 12, 2020

Conversation

barthap
Copy link
Contributor

@barthap barthap commented Aug 10, 2020 •
edited

Why

Fixes #9635

Android 10 seems not to support SQL functions (COUNT(*), GROUP BY etc.) in ContentResolver queries. [source]

Also, MediaLibrary.getAlbumsAsync() did not work properly on Android.

How

Rewrite some expo-media-library methods, which used those statements.

  • Fixed getAlbumsAsync(). Rewritten method in Kotlin.
  • Fixed getAlbum().
  • Fixed MediaLibrary listener onChange() event.
  • Other minor fixes.
  • Cleanup.

Test Plan

  • Native unit tests
  • Test suite
  • NCL
  • Demo app ran on API level 29+.
  • Demo app ran on API level < 29

@barthap barthap requested a review from lukmccall August 10, 2020 13:47
@github-actions
Copy link
Contributor

Native Component List for this branch is ready

@barthap barthap mentioned this pull request Aug 10, 2020
Closed
@barthap barthap changed the title [media-library] Fix getAlbumsAsync() crashes on Android 10 [media-library] Fix getAlbumsAsync() crashing on Android 10 Aug 11, 2020
@barthap barthap marked this pull request as ready for review August 11, 2020 09:56
@barthap barthap requested a review from tsapeta as a code owner August 11, 2020 09:56
@barthap barthap requested a review from lukmccall August 12, 2020 07:31
@lukmccall lukmccall merged commit db67660 into master Aug 12, 2020
@lukmccall lukmccall deleted the @barthap/media-library/albums-android branch August 12, 2020 07:33
@barthap barthap mentioned this pull request Aug 13, 2020
Closed
@ide ide mentioned this pull request Aug 14, 2020
Closed
@barthap barthap mentioned this pull request Sep 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsapeta tsapeta tsapeta approved these changes

@lukmccall lukmccall lukmccall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[expo-media-library] Invalid column COUNT(*) exception on Android 10.
3 participants
@barthap @tsapeta @lukmccall