[eas-shared] Add support for installing iOS .app files from custom ta…

…rballs (#193)

* [eas-shared] Add support for installing iOS .app files from custom tarballs

* Add changelog entry

CHANGELOG.md

@@ -11,6 +11,7 @@
 ### 🐛 Bug fixes
 
 - Fix extra avd info being displayed as a bootable android emulator. ([#190](https://github.com/expo/orbit/pull/190) by [@gabrieldonadel](https://github.com/gabrieldonadel))
+- Fix installing iOS apps from tarballs that don't contain an `.app` or `.ipa` file. ([#193](https://github.com/expo/orbit/pull/193) by [@gabrieldonadel](https://github.com/gabrieldonadel))
 
 ### 💡 Others
 

packages/eas-shared/src/download.ts

@@ -127,7 +127,7 @@ export async function downloadAndMaybeExtractAppAsync(url: string): Promise<stri
   const outputDir = path.join(_downloadsCacheDirectory(), `${name}`);
   if (await fs.pathExists(outputDir)) {
     try {
-      const appPath = await getAppPathAsync(outputDir, '(apk|app|ipa)');
+      const appPath = await getAppPathAsync(outputDir);
       return appPath;
     } catch (error) {
       if (error instanceof InternalError) {
@@ -164,7 +164,7 @@ export async function downloadAndMaybeExtractAppAsync(url: string): Promise<stri
     );
     await tarExtractAsync(tmpArchivePath, outputDir);
 
-    const appPath = await getAppPathAsync(outputDir, '(apk|app|ipa)');
+    const appPath = await getAppPathAsync(outputDir);
 
     return appPath;
   }
@@ -176,16 +176,24 @@ export async function extractAppFromLocalArchiveAsync(appArchivePath: string): P
 
   await tarExtractAsync(appArchivePath, outputDir);
 
-  return await getAppPathAsync(outputDir, '(apk|app|ipa)');
+  return await getAppPathAsync(outputDir);
 }
 
-async function getAppPathAsync(outputDir: string, applicationExtension: string): Promise<string> {
-  const appFilePaths = await glob(`./**/*.${applicationExtension}`, {
+async function getAppPathAsync(outputDir: string): Promise<string> {
+  const applicationExtensionGlob = '(apk|app|ipa)';
+  const appFilePaths = await glob(`./**/*.${applicationExtensionGlob}`, {
     cwd: outputDir,
     onlyFiles: false,
   });
 
   if (appFilePaths.length === 0) {
+    // Check if outputDir is an .app but was extracted as folder
+    if (fs.existsSync(path.join(outputDir, 'Info.plist'))) {
+      const appPath = `${outputDir}.app`;
+      await fs.promises.cp(outputDir, appPath, { recursive: true });
+      return appPath;
+    }
+
     throw Error('Did not find any installable apps inside tarball.');
   }