Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Read auth credentials from menu-bar MMKV storage #137

Merged
merged 1 commit into from Jan 18, 2024

Conversation

gabrieldonadel
Copy link
Member

Why

Fetching specific data from an Expo update requires the request to be authenticated, and given that this logic will be handled by the CLI we need to add support for sharing auth credentials between the cli and the menu-bar

Related to #134

How

  • Add nodejs-mmkv dependency to access the same MMKV instance used by the menu-bar
  • Add homedir constant to MenuBarModule
  • Move MMKV path to the same folder as other expo apps (e.g. expo-cli and eas-cli)

Test Plan

  • Run menu-bar and ensure all data is being migrated correctly
  • Run cli and read session secret using getSessionSecret

@gabrieldonadel gabrieldonadel merged commit 2401e1f into main Jan 18, 2024
1 check passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/cli-auth branch January 18, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-check Skips changelog check step.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants