Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu-bar] Add electron support for WindowManager #158

Merged
merged 6 commits into from Feb 5, 2024

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Jan 31, 2024

Why

Closes ENG-11332

How

  • Add electron support for WindowManager
  • Update web index file to load window based on moduleName, similar to [[RCTRootView alloc] initWithBridge:bridge moduleName:moduleName initialProperties:@{}];
  • Add SparkleModule mock for web
  • Add missing openPopover and closePopover functions to MenuBarModule

Test Plan

On Windows:

Screen.Recording.2024-02-02.at.15.01.48.mov

@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-window-manager branch from 6702bb5 to d702796 Compare January 31, 2024 16:58
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-auto-resizer-root-view branch 2 times, most recently from 2e8e5ef to 684b4cc Compare February 1, 2024 13:50
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-window-manager branch from bf863e2 to b53499c Compare February 1, 2024 13:51
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-auto-resizer-root-view branch from 684b4cc to 0ea95d6 Compare February 2, 2024 13:52
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-window-manager branch from b53499c to 462c813 Compare February 2, 2024 16:52
Copy link

linear bot commented Feb 2, 2024

Base automatically changed from @gabrieldonadel/electron-auto-resizer-root-view to main February 2, 2024 17:31
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-window-manager branch from 9fd0d0f to 77361ae Compare February 2, 2024 18:14
@gabrieldonadel gabrieldonadel marked this pull request as ready for review February 2, 2024 18:14
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/electron-window-manager branch from 768582e to cee8796 Compare February 5, 2024 22:21
@gabrieldonadel gabrieldonadel merged commit c7f5c1c into main Feb 5, 2024
1 check passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/electron-window-manager branch February 5, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant