Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu-bar][electron] Fix forge building config #185

Merged
merged 7 commits into from Feb 29, 2024

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Feb 29, 2024

Why

After the first round of testing RC0 internally some issues where reported, this PR fixes all of these

How

  • Fix CLI vite config (Crypto.getRandomValues() not supported. error)
  • Add tray .ico file specific for Windows along with one image for dark mode and another for light mode
  • Fix popover position when resizing on Windows
  • Fix Control Panel ➡ Programs and Features icon

Test Plan

1.mov

@gabrieldonadel gabrieldonadel marked this pull request as ready for review February 29, 2024 12:49
@gabrieldonadel gabrieldonadel merged commit f7fa84f into main Feb 29, 2024
1 of 2 checks passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/fix-electron-building branch February 29, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants