[menu-bar] Terminate Auto Launcher after launching main Orbit application #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-9963 AutoLauncher process keeps running even after launching the main app
The AutoLauncher process should be terminated after successfully launching Orbit otherwise users will see the AutoLauncher process in their Action Monitor running all the time, even after closing Orbit, which sounds dodgy. |
gabrieldonadel
deleted the
@gabrieldonadel/terminate-auto-launcher-process
branch
gabrieldonadel
added a commit
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-9963
How
The AutoLauncher process should be terminated after successfully launching Orbit otherwise users will see the AutoLauncher process in their Action Monitor running all the time, even after closing Orbit, which sounds dodgy.
Test Plan
Build using the AutoLauncher scheme and ensure Orbit is launched and the AutoLauncher process is terminated
Screen.Recording.2023-09-01.at.00.51.14.mov