Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Native Maps to 0.22.1 for critical bugfix #1

Closed
wants to merge 3 commits into from

Conversation

vpontis
Copy link

@vpontis vpontis commented Nov 9, 2018

Does any other open PR do the same thing?

No.

What issue is this PR fixing?

Fix for “The specified child already has a parent”

react-native-maps#2545

How did you test this PR?

I need help w/ testing this locally... Do I need to fork the expo repo and then have that forked expo repo point to this repo?

@vpontis vpontis changed the title Expo 0.22.1 Update React Native Maps to 0.22.1 for critical bugfix Nov 9, 2018
@sjchmiela
Copy link

Hey! Thank you for your contribution! I'm sorry I didn't see it before I updated this repository with 0.22.1 release. expo#master points now to the 0.22.1 release, we'll update Android runtime soon. 🙂

@sjchmiela sjchmiela closed this Nov 10, 2018
@vpontis
Copy link
Author

vpontis commented Nov 10, 2018

Thanks @sjchmiela

I think I'm confused tho, I don't see the v0.22.1 release in this repo. https://github.com/expo/react-native-maps/tree/v0.22.1 gives a 404

And in the expo repo it's still pointing to 0.22.0 https://github.com/expo/expo/blob/master/packages/expo/package.json

What am I missing?

@sjchmiela
Copy link

First we have to merge this PR expo/expo#2680 and then rebuild Expo Client and Turtle shell app. 🙂 I wish to wait with this until Monday to let everyone enjoy their weekends.

@vpontis
Copy link
Author

vpontis commented Nov 10, 2018

Ah gotcha, I didn't realize about all of those steps. Thanks @sjchmiela :)

You're doing great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants