Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queryString import in getPathFromState and getStateFromPath fails when using query-string v8 and above #344

Closed
sbkl opened this issue Mar 4, 2023 · 1 comment · Fixed by #353

Comments

@sbkl
Copy link

sbkl commented Mar 4, 2023

Summary

In both getPathFromState.ts and getStateFromPath.ts files, the query-string library is imported like so:

import * as queryString from "query-string";

When I install the query-string v8 library, the compilation fails. Works properly with query-string v7.

By simply replacing the import with import queryString from "query-string", the compilation error disappear and the app runs properly with query-string v8.

Would it be possible to upgrade query-string v8 and update the imports accordingly?

I believe this is the same issue mentioned in the last comment than #323

Minimal reproducible example

Here is a repo with the expo-router template and query-string v8 installed: repo

@xinha-sh
Copy link

@EvanBacon This doesn't work when in a monorepo other package is using query-string v8. Is there a specific reason for opting for query-string package instead of using URLSearchParams ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants