Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lock query-string version to prevent hoisting issues #353

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

marklawlor
Copy link
Contributor

Motivation

Fixes #344 #323

expo-router uses query-string without setting a dependency version. By default this will use v7 (supplied by @react-navigation/native uses), however if any other package installs v8, expo-router will use the hoisted version.

We should lock to the same major version as @react-navigation/native

Note query-string@8 moved to esm, which is why things are breaking.

@EvanBacon EvanBacon merged commit 4086e5d into main Mar 7, 2023
@EvanBacon EvanBacon deleted the 344 branch March 7, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

queryString import in getPathFromState and getStateFromPath fails when using query-string v8 and above
2 participants