Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snackager] Add explicit RN web external for react native maps #283

Merged
merged 1 commit into from May 5, 2022

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented May 5, 2022

Why

Currently, bundling of react-native-maps@0.29.4 fails with the error:

Failed to resolve dependency 'react-native-maps@0.29.4' (Module not found: Error: Package path ./unstable-native-dependencies is not exported from package /tmp/snackager/snackager/buildStatus/1/react-native-maps@0.29.4-ios,android,web/package/node_modules/react-dom (see exports field in /tmp/snackager/snackager/buildStatus/1/react-native-maps@0.29.4-ios,android,web/package/node_modules/react-dom/package.json)
Retry
Module not found: Error: Package path ./unstable-native-dependencies is not exported from package /tmp/snackager/snackager/buildStatus/1/react-native-maps@0.29.4-ios,android,web/package/node_modules/react-dom (see exports field in /tmp/snackager/snackager/buildStatus/1/react-native-maps@0.29.4-ios,android,web/package/node_modules/react-dom/package.json))

In this run you can see that react-dom and react-native-web are getting sucked into the bundle.

How

  • Added explicit RN web external to avoid react-dom getting sucked into the bundle.

Test Plan

  • See if bundling passes with this change

@byCedric
Copy link
Member Author

byCedric commented May 5, 2022

@byCedric byCedric merged commit d5ac534 into main May 5, 2022
@byCedric byCedric deleted the @bycedric/snackager/add-rn-web-external-rn-maps branch May 5, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant