Upgrade Snack to Expo SDK 46 beta #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Runtime deployment issues were caused by the new CLI. I replaced |
This defers security to GitHub and environments to prevent accidential deployments. Locally, you have to add this environment variable to enable pushing, which is an opt-in and prevents accidental pushes too
byCedric
force-pushed
the
refactor/upgrade-sdk-46-beta
branch
from
ef287ef
to
3a7c73a
Compare
Not sure why this is necessary, probably good to check on this after stable release
byCedric
force-pushed
the
refactor/upgrade-sdk-46-beta
branch
from
288c0aa
to
dfafb0c
Compare
brentvatne
reviewed
Jul 20, 2022
| @@ -1,3 +1,11 @@ | |||
| import * as Amplitude from 'expo-analytics-amplitude'; | |||
| // Disable Amplitude for SDK 46 | |||
There was a problem hiding this comment.
ah - i didn't realize that we were using this in the snack runtime 😰
There was a problem hiding this comment.
I already pinged @tcdavis, but we aren't using analytics from the Runtime anymore. So should be good :)
* [snackager] Add babel proposal export namespace from for reanimated * [snackager] Add test for react native reanimated 2.9.1 * [snackager] Add reanimated as external for skia since its bundled inside the runtime * [snackager] Remove reanimated hidden peer dep because it can now bundle * [snackager] Update bundling snapshot for reanimated 2.9.1
|
Change of plans, I'm squashing all the SDK 46 PRs into |
byCedric
added a commit
that referenced
this pull request
Aug 2, 2022
* [runtime] Upgrade to expo sdk 46 beta * [runtime] Change app.json to sdk 46 * [runtime] Change entrypoint to index * [runtime] Customized web files * [runtime] Disable unknown exceptions in typescript * [runtime] Remove react 17 types with resolutions This is caused by DefinitelyTyped/DefinitelyTyped#59862 * [runtime] Upgrade eslint to latest version for typescript * [runtime] Fix all new eslint errors * [docs] Change upgrade instructions to match snack-content types * [snack-content] Update SDK types dropping 43 and adding 46 * [snack-sdk] Update all tests for sdk 46 * [snack-sdk] Update snapshots for sdk 46 * [website] Update sdk list for sdk 46 * [website] Update snapshots for sdk 46 * [snackager] Update snapshot tests for sdk 46 * [runtime] Switch to expo export:web for web deployments * [runtime] Force old expo-cli for publish * [runtime] Update all patches to latest versions * [CI] Use opt-in to skaffold push to allow custom branches This defers security to GitHub and environments to prevent accidential deployments. Locally, you have to add this environment variable to enable pushing, which is an opt-in and prevents accidental pushes too * [runtime] Disable Amplitude since its unavailable for SDK 46 * [runtime] Add babel polyfill in production app Not sure why this is necessary, probably good to check on this after stable release * [runtime] Bump snack-babel-standalone to version to 1.1.0 * [CI] Allow runtime to take 4gb when publishing * [snack-content] Set SDK 46 as default SDK for web * [snackager] Fix bundling react-native-reanimated@2.9.1 (#316) * [snackager] Add babel proposal export namespace from for reanimated * [snackager] Add test for react native reanimated 2.9.1 * [snackager] Add reanimated as external for skia since its bundled inside the runtime * [snackager] Remove reanimated hidden peer dep because it can now bundle * [snackager] Update bundling snapshot for reanimated 2.9.1 * [snackager] Update snapshot tests for default sdk 46 * [snack-sdk] Update snapshot tests for default sdk 46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We need to upgrade to SDK 46, this is a test run to see what will happen during the beta.
How
Followed the steps in ./docs/expo-sdk-upgrade.md
Test Plan
After everything seems ok,
I'll manually deploy it to staging (without merging to main).Done!