Skip to content
This repository has been archived by the owner on Apr 7, 2023. It is now read-only.

Update XDL to remove check-dynamic-macros call #212

Merged
merged 3 commits into from Apr 20, 2020

Conversation

sjchmiela
Copy link
Contributor

Checklist

  • I've read the Contribution Guidelines.
  • I've updated the CHANGELOG if necessary.
  • I've ensured the unit and smoke tests are still passing - either by running yarn test:unit and yarn test:smoke:[ios|android] or by checking the appropriate CircleCI builds' statuses.
  • I've manually tested whether the changes I made work as expected.

Motivation and Context

See expo/expo-cli#1933.

Description

Updates XDL so it includes change introduced in expo/expo-cli#1933.

@sjchmiela sjchmiela requested a review from dsokal April 20, 2020 13:08
Copy link
Contributor

@dsokal dsokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a changelog entry - it's user-facing - turtle-cli would call the removed script.

@sjchmiela sjchmiela merged commit b48f890 into master Apr 20, 2020
@sjchmiela sjchmiela deleted the @sjchmiela/remove-check-dynamic-macros branch April 20, 2020 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants