Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python 3 7 #235

Merged
merged 1 commit into from
Mar 3, 2024
Merged

drop python 3 7 #235

merged 1 commit into from
Mar 3, 2024

Conversation

expobrain
Copy link
Owner

@expobrain expobrain commented Mar 3, 2024

Summary by CodeRabbit

  • Chores
    • Updated the pyupgrade hook to enhance compatibility with Python 3.9 and newer versions, ensuring more efficient code upgrades while maintaining runtime typing.

Copy link

coderabbitai bot commented Mar 3, 2024

Walkthrough

The modification enhances the project's Python version compliance by upgrading the pyupgrade tool configuration within the .pre-commit-config.yaml file. This adjustment shifts the Python syntax upgrading from targeting Python 3.7 and above (--py37-plus) to focusing on Python 3.9 and above (--py39-plus). Additionally, it retains the --keep-runtime-typing parameter, ensuring that runtime typing behavior is preserved during the upgrade process.

Changes

File(s) Change Summary
.pre-commit-config.yaml Updated pyupgrade to --py39-plus, kept --keep-runtime-typing

🐇✨
In the land of code and byte,
A rabbit hopped with great delight.
"To Python 3.9, we leap ahead,
With pyupgrade as our guiding thread.
Let's keep our typings safe and sound,
In this digital burrow we've found."
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@expobrain
Copy link
Owner Author

@coderabbitai review

@expobrain expobrain marked this pull request as ready for review March 3, 2024 20:19
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 2059668 and 7152ee5.
Files selected for processing (1)
  • .pre-commit-config.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .pre-commit-config.yaml

@expobrain expobrain merged commit 6288261 into main Mar 3, 2024
6 checks passed
@expobrain expobrain deleted the drop_python_3_7 branch March 3, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant