Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request - split out dompdf into a separate git repo as a git submodule #797

Closed
exponentcms opened this issue Apr 28, 2020 · 4 comments
Closed

Feature request - split out dompdf into a separate git repo as a git submodule #797

exponentcms opened this issue Apr 28, 2020 · 4 comments
Assignees
@dleffler
Labels
3rd party library feature request a new feature not yet incorporated into the code pdf

Comments

@exponentcms
Copy link
Owner

Just as we're going to do with themes, we shoudl also submodule'ize the optional dompdf package
@exponentcms
Copy link
Owner Author

(from [e6437ddb91db1f0aa9029119b508da9bca2d2316]) Removes /themes and /external/dompdf to be converted into submodules...on the develop branch this time [#659 #749]
e6437dd

@exponentcms
Copy link
Owner Author

(from [c1f35f16d674c401e3cd5ce010e54261435b09ae]) (re) adds /themes and /external/dompdf now converted into submodules...on the develop branch this time [#659 #749]
c1f35f1

@exponentcms
Copy link
Owner Author

We'll call this one implemented though we probably won't know the full impact until we move it into the master branch (you auto-checkout master when you clone a repo?)

@exponentcms
Copy link
Owner Author

Lighthouse URL: https://exponentcms.lighthouseapp.com/projects/61783/tickets/749

@exponentcms exponentcms mentioned this issue Apr 28, 2020
Closed
@exponentcms exponentcms added the feature request a new feature not yet incorporated into the code label Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dleffler dleffler

Labels
3rd party library feature request a new feature not yet incorporated into the code pdf
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dleffler @exponentcms